Fixed random clock period generation #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiceShelley
force-pushed
the
rice/cocotb_random_clk_period_generation
branch
from
40b3229 to
9bf46e1
Compare
RiceShelley
force-pushed
the
rice/cocotb_random_clk_period_generation
branch
from
9bf46e1 to
2aa04e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When randomly generating clock periods old implementation would on occasion select a clock period that could not be represented by the resolution of the simulator causing the test to fail.
Fix:
Use Decimal class and strings to generate a random number with only N decimal places.