Skip to content

Remove no longer needed exclusions from pulsar-client-all #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Remove no longer needed exclusions from pulsar-client-all #1064

merged 1 commit into from
Aug 14, 2025

Conversation

therepanic
Copy link
Contributor

The improvements introduced in this PR include handling javax.activation via shading and migrating from javax to jakarta. Given these changes, we should remove some of the now unnecessary exclusions.

Fix #963

@therepanic therepanic force-pushed the remove-no-longer-needed-exclusions-from-pulsar-client-all branch from 083bda2 to 2fcf1a3 Compare March 17, 2025 18:40
@onobc
Copy link
Collaborator

onobc commented Mar 17, 2025

Hi @panic08 - great to see you over here in this project 👋🏻

We just released 1.1.10 and 1.2.4 but will get this merged in soon. We intentionally did not add this change in yet as shadowing, transitive deps, and dependencies in general can be risky beyond the surface, especially when we have something like:

  • spring-boot (uses)
    • pulsar-client-all
    • spring-pulsar
    • pulsar-client-reactive
      and
  • spring-pulsar (uses)
    • pulsar-client-all
    • pulsar-client-reactive
      and
  • pulsar-client-reactive (uses)
    • pulsar-client-all

Thank you very much for the contribution. Once we branch main into 1.2.x and main is then our target for 2.0.0 we will merge this.

@onobc onobc modified the milestones: 2.0.0, 2.0.0-M1 Mar 27, 2025
@onobc onobc removed this from the 2.0.0-M1 milestone Jun 24, 2025
@therepanic @onobc
Cleanup exclusions from pulsar-client-all dependency
3eaaae8 
This commit removes the no longer needed exclusion of `com.sun.activation`
from the pulsar-client-all dependency.

Fixes spring-projects#963

Signed-off-by: Andrey Litvitski <[email protected]>
@onobc onobc force-pushed the remove-no-longer-needed-exclusions-from-pulsar-client-all branch from 2fcf1a3 to 3eaaae8 Compare August 14, 2025 20:21
onobc
onobc reviewed Aug 14, 2025
View reviewed changes
spring-pulsar/spring-pulsar.gradle
@@ -9,7 +9,6 @@ dependencies {
api 'io.micrometer:micrometer-observation'
api (libs.pulsar.client.all) {
exclude group: 'org.apache.logging.log4j'
exclude group: 'com.sun.activation', module: 'javax.activation'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therepanic I too thought javax.activation was now being excluded from pulsar-client-all, but it is still present in 4.0.6. So we need to keep this exclusion in place.

However, com.sun.activation was removed in version 3.3.3 and you can see it present in 3.3.2 so we can leave this removal in place.

I pushed a commit and squashed it into your PR as I want to get this one merged in today.

@onobc onobc merged commit 0220d21 into spring-projects:main Aug 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onobc onobc onobc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove no longer needed exclusions from pulsar-client-all
2 participants
@therepanic @onobc