Skip to content

Remove no longer needed exclusions from pulsar-client-all #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion spring-pulsar/spring-pulsar.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ dependencies {
api 'io.micrometer:micrometer-observation'
api (libs.pulsar.client.all) {
exclude group: 'org.apache.logging.log4j'
exclude group: 'com.sun.activation', module: 'javax.activation'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therepanic I too thought javax.activation was now being excluded from pulsar-client-all, but it is still present in 4.0.6. So we need to keep this exclusion in place.

However, com.sun.activation was removed in version 3.3.3 and you can see it present in 3.3.2 so we can leave this removal in place.

I pushed a commit and squashed it into your PR as I want to get this one merged in today.

exclude group: 'javax.validation', module: 'validation-api'
exclude group: 'com.google.protobuf', module: 'protobuf-java'
}
Expand Down