Skip to content

Support colima #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

goshlanguage
Copy link

@goshlanguage goshlanguage commented Aug 8, 2025

I needed to add colima in order to use thv in my current setup. Opening as draft as I'm traveling as I write this PR and haven't given due diligence of going through the Dev Guide. Hoping to share for guidance.

Before:

bin/thv client setup                       
A new version of ToolHive is available: v0.2.5
Currently running: v8ef1a70-dirty
Error: failed to create client manager: no supported container runtime available: container runtime not found

After:

bin/thv client setup
A new version of ToolHive is available: v0.2.5
Currently running: v8ef1a70-dirty
Successfully registered client: vscode
Successfully registered client: cursor
10:02AM INF Creating new client config file at /Users/rhartje/Library/Application Support/Code/User/mcp.json
10:02AM INF Creating new client config file at /Users/rhartje/.cursor/mcp.json

@@ -186,6 +186,8 @@ const (
TypeDocker Type = "docker"
// TypeKubernetes represents the Kubernetes runtime
TypeKubernetes Type = "kubernetes"
// TypeColima represents the Colima runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary - it looks like you are using the Docker runtime to connect to Colima. This enum is used for different implementations of our runtime interface.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In review, I'm checking in the Docker runtime if there is a path override in the Docker runtime check, but I'm also checking explicitly if its Colima:
https://github.com/stacklok/toolhive/pull/1332/files#diff-d58624f599f4b93a4c84d22c3d24888c6a2c57855eb451ccc72815d5cda9667bR88-R94

I'd like not to remove this, because if I do, then the user has to know and explicitly override the Docker socket to the Colima socket, which requires discovery of this in the docs or otherwise.

What are your thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmjb
Copy link
Member

dmjb commented Aug 13, 2025

@goshlanguage This makes sense to me. Feel free to update the branch and take it out of draft status.

@goshlanguage goshlanguage marked this pull request as ready for review August 13, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants