Skip to content

[Store] Do not finalize the classes anymore #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[Store] Do not finalize the classes anymore #724

merged 1 commit into from
Oct 3, 2025
+6 −6

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Oct 3, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #366 (comment)
License MIT

@carsonbot carsonbot added Store Issues & PRs about the AI Store component Status: Needs Review labels Oct 3, 2025
@lyrixx lyrixx changed the title [Store][ClickHouse] Do not finalize the class anymore [Store] Do not finalize the classes anymore Oct 3, 2025
@OskarStark
Copy link
Contributor

Thank you @lyrixx.

@OskarStark OskarStark merged commit 65b96e3 into symfony:main Oct 3, 2025
17 checks passed
@lyrixx lyrixx deleted the ch branch October 3, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Store Issues & PRs about the AI Store component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @OskarStark @carsonbot