Skip to content

Remove implementation of traits that can confuse users because of lack well-defining meaning - #1007

Merged
dralley merged 1 commit into
tafia:masterfrom
Mingun:remove-confusing-traits
Aug 22, 2026
Merged

dralley merged 1 commit into
tafia:masterfrom
Mingun:remove-confusing-traits

Conversation

@Mingun

@Mingun Mingun commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

@Mingun
Mingun requested a review from dralley August 22, 2026 17:04
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.28%. Comparing base (e00ae5c) to head (7cd0fe9).
⚠️ Report is 64 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   57.31%   55.28%   -2.04%     
==========================================
  Files          46       51       +5     
  Lines       18197    18721     +524     
==========================================
- Hits        10429    10349      -80     
- Misses       7768     8372     +604     
Flag Coverage Δ
unittests 55.28% <ø> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dralley
dralley merged commit 41efc22 into tafia:master Aug 22, 2026
7 checks passed
@Mingun
Mingun deleted the remove-confusing-traits branch August 22, 2026 17:29
@Mingun

Mingun commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

@dralley, It seems that this PR was not included in v0.42.0, because you pushed release before it was merged 😕

@dralley

dralley commented Aug 22, 2026 •

Copy link
Copy Markdown
Collaborator

I did merge it first. Looking at the chain of events, it looks like I just forgot to get fetch upstream before I rebased against upstream/master and created the local tag.

(which in hindsight is an error-prone workflow, should have just switched back to master branch and git pull upstream master, and done the tagging there - less chance of mistakes).

Sorry. Would you like to see a re-release as 0.42.1, or just move it to the Unreleased section?

@Mingun

Mingun commented Aug 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

Removing trait implementation would be a breaking change. I suggest to following course of actions:

  • force-push master to match the v0.42.0 tag
  • cherry-pick this PR with edits to put it Unreleased section
  • release v0.43.0 with the fix

Just did the first two points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants