Skip to content

Remove implementation of traits that can confuse users because of lack well-defining meaning #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dralley merged 1 commit into from
Aug 22, 2026
+7 −7
Merged

Remove implementation of traits that can confuse users because of lack well-defining meaning #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ The MSRV has been raised to 1.86.
- [#1002]: Added `Deserializer::resolver` and `Deserializer::resolver_mut` methods
to get a namespace resolver used by this deserializer, because it no longer uses
an `NsReader` internally.
- [#1005]: Implement `Hash`, `PartialOrd`, and `Ord` across all `Bytes*` types.
- [#1005]: Implement `Hash`, `PartialOrd`, and `Ord` for `BytesText` and `BytesCData` types.

[#269]: https://github.com/tafia/quick-xml/issues/269
[#331]: https://github.com/tafia/quick-xml/issues/331
Expand Down
12 changes: 6 additions & 6 deletions src/events/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ use attributes::{AttrError, Attribute, Attributes};
/// [`local_name`]: Self::local_name
/// [`attributes`]: Self::attributes
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Eq, PartialEq)]
pub struct BytesStart<'i> {
/// content of the element
pub(crate) buf: Cow<'i, str>,
Expand Down Expand Up @@ -399,7 +399,7 @@ impl<'i> arbitrary::Arbitrary<'i> for BytesStart<'i> {
/// [`name`]: Self::name
/// [`local_name`]: Self::local_name
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Eq, PartialEq)]
pub struct BytesEnd<'i> {
name: Cow<'i, str>,
}
Expand Down Expand Up @@ -1043,7 +1043,7 @@ impl FusedIterator for CDataIterator<'_> {}
///
/// [PI]: https://www.w3.org/TR/xml11/#sec-pi
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Eq, PartialEq)]
pub struct BytesPI<'i> {
content: BytesStart<'i>,
}
Expand Down Expand Up @@ -1228,7 +1228,7 @@ impl<'i> arbitrary::Arbitrary<'i> for BytesPI<'i> {
/// using [`.into_owned()`].
///
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct BytesDecl<'i> {
content: BytesStart<'i>,
}
Expand Down Expand Up @@ -1586,7 +1586,7 @@ impl<'i> arbitrary::Arbitrary<'i> for BytesDecl<'i> {
/// using [`.into_owned()`].
///
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Eq, PartialEq)]
pub struct BytesRef<'i> {
content: Cow<'i, str>,
}
Expand Down Expand Up @@ -1777,7 +1777,7 @@ impl<'i> arbitrary::Arbitrary<'i> for BytesRef<'i> {
///
/// [`Reader::read_event_into`]: crate::reader::Reader::read_event_into
/// [`.into_owned()`]: Self::into_owned
#[derive(Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
#[derive(Clone, Debug, Eq, PartialEq)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
pub enum Event<'i> {
/// Start tag (with attributes) `<tag attr="value">`.
Expand Down
Loading