Skip to content

Conversation

wilderbridge
Copy link

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Aug 29, 2025
Copy link

linux-foundation-easycla bot commented Aug 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wilderbridge / name: Niklas Siltakorpi (8f5df0e)

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2025
@wilderbridge
Copy link
Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2025
@wilderbridge wilderbridge marked this pull request as ready for review August 29, 2025 13:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2025
@waveywaves
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 29, 2025
@wilderbridge wilderbridge force-pushed the fix/enabletektonocibundles branch from 27809c6 to 8f5df0e Compare September 1, 2025 07:41
@wilderbridge
Copy link
Author

/retest

1 similar comment
@waveywaves
Copy link
Member

/retest

@l-qing
Copy link
Member

l-qing commented Sep 2, 2025

I also encountered another similar field, ScopeWhenExpressionsToTask, when upgrading from Tekton Pipeline 0.56 to 0.65.

@wilderbridge
Copy link
Author

/retest

2 similar comments
@wilderbridge
Copy link
Author

/retest

@waveywaves
Copy link
Member

/retest

@waveywaves waveywaves self-assigned this Sep 29, 2025
EnableConciseResolverSyntax bool `json:"enableConciseResolverSyntax,omitempty"`
EnableKubernetesSidecar bool `json:"enableKubernetesSidecar,omitempty"`
EnableWaitExponentialBackoff bool `json:"enableWaitExponentialBackoff,omitempty"`
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"EnableTektonOCIBundles,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"EnableTektonOCIBundles,omitempty"`
// DeprecatedEnableTektonOCIBundles is maintained for backward compatibility
// to allow deletion of PipelineRuns created before v0.62.x.
// This field is not used and can be removed in a future release
// once we're confident old PipelineRuns have been cleaned up.
// See issue #8359 for context.
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"enableTektonOCIBundles,omitempty"`

add a explanation comment and fix casing in the yaml tag

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from waveywaves after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

featureFlags.EnableTektonOCIBundles becomes unknown fields
4 participants