Skip to content

accept featureFlags.EnableTektonOCIBundles to fix unknown field error #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

accept featureFlags.EnableTektonOCIBundles to fix unknown field error #8996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/300-crds/300-pipelinerun.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2205,6 +2205,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -2620,6 +2622,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -2909,6 +2913,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -5138,6 +5144,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down
8 changes: 8 additions & 0 deletions config/300-crds/300-taskrun.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,6 +1776,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -2065,6 +2067,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -3771,6 +3775,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down Expand Up @@ -4026,6 +4032,8 @@ spec:
enableStepActions:
description: EnableStepActions is a no-op flag since StepActions are stable
type: boolean
enableTektonOCIBundles:
type: boolean
enableWaitExponentialBackoff:
type: boolean
enforceNonfalsifiability:
Expand Down
24 changes: 16 additions & 8 deletions pkg/apis/config/feature_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const (
runningInEnvWithInjectedSidecarsKey = "running-in-environment-with-injected-sidecars"
awaitSidecarReadinessKey = "await-sidecar-readiness"
requireGitSSHSecretKnownHostsKey = "require-git-ssh-secret-known-hosts" //nolint:gosec
// enableTektonOCIBundles = "enable-tekton-oci-bundles"
EnableTektonOCIBundles = "enable-tekton-oci-bundles"

enableAPIFields = "enable-api-fields"
sendCloudEventsForRuns = "send-cloudevents-for-runs"
Expand Down Expand Up @@ -175,6 +175,13 @@ var (
Stability: AlphaAPIFields,
Enabled: DefaultAlphaFeatureEnabled,
}

DefaultEnableTektonOCIBundles = PerFeatureFlag{
Name: EnableTektonOCIBundles,
Stability: AlphaAPIFields,
Enabled: DefaultAlphaFeatureEnabled,
Deprecated: true,
}
)

// FeatureFlags holds the features configurations
Expand Down Expand Up @@ -203,13 +210,14 @@ type FeatureFlags struct {
Coschedule string `json:"coschedule,omitempty"`
EnableCELInWhenExpression bool `json:"enableCELInWhenExpression,omitempty"`
// EnableStepActions is a no-op flag since StepActions are stable
EnableStepActions bool `json:"enableStepActions,omitempty"`
EnableParamEnum bool `json:"enableParamEnum,omitempty"`
EnableArtifacts bool `json:"enableArtifacts,omitempty"`
DisableInlineSpec string `json:"disableInlineSpec,omitempty"`
EnableConciseResolverSyntax bool `json:"enableConciseResolverSyntax,omitempty"`
EnableKubernetesSidecar bool `json:"enableKubernetesSidecar,omitempty"`
EnableWaitExponentialBackoff bool `json:"enableWaitExponentialBackoff,omitempty"`
EnableStepActions bool `json:"enableStepActions,omitempty"`
EnableParamEnum bool `json:"enableParamEnum,omitempty"`
EnableArtifacts bool `json:"enableArtifacts,omitempty"`
DisableInlineSpec string `json:"disableInlineSpec,omitempty"`
EnableConciseResolverSyntax bool `json:"enableConciseResolverSyntax,omitempty"`
EnableKubernetesSidecar bool `json:"enableKubernetesSidecar,omitempty"`
EnableWaitExponentialBackoff bool `json:"enableWaitExponentialBackoff,omitempty"`
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"EnableTektonOCIBundles,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"EnableTektonOCIBundles,omitempty"`
// DeprecatedEnableTektonOCIBundles is maintained for backward compatibility
// to allow deletion of PipelineRuns created before v0.62.x.
// This field is not used and can be removed in a future release
// once we're confident old PipelineRuns have been cleaned up.
// See issue #8359 for context.
DeprecatedEnableTektonOCIBundles *bool `json:"enableTektonOCIBundles,omitempty" yaml:"enableTektonOCIBundles,omitempty"`

add a explanation comment and fix casing in the yaml tag

}

// GetFeatureFlagsConfigName returns the name of the configmap containing all
Expand Down
5 changes: 5 additions & 0 deletions pkg/apis/config/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/pipeline/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading