feat: Expose envconfig functionality through C bridge #986
Conversation
THardy98
force-pushed
the
expose_envconfig_c_bridge
branch
from
240b196 to
9a9cbe7
Compare
There was a problem hiding this comment.
Minor suggestions. Also, can we submit use of this (which I am guessing is at temporalio/sdk-dotnet#509) for PR review before merging this just to make sure we're good there from a review POV? We can basically merge both at once when both approved (obviously this first and submodule update over there).
|
|
||
| /// Load a single client profile from given sources with env overrides | ||
| #[unsafe(no_mangle)] | ||
| pub extern "C" fn temporal_core_client_config_profile_load( |
There was a problem hiding this comment.
Can you be a bit more specific in docs on what format the callback receives on success and fail? They are just byte arrays, so we can be a bit clearer. Can do this in the callback docs instead of here if easier.
|
|
||
| /// Load a single client profile from given sources with env overrides | ||
| #[unsafe(no_mangle)] | ||
| pub extern "C" fn temporal_core_client_config_profile_load( |
There was a problem hiding this comment.
There are several parameters here. I think it'd be ok if we accepted a ClientConfigProfileLoadOptions struct with all of this in it instead. Similarly, would have a ClientConfigLoadOptions for the other exposed function.
|
|
||
| /// Load all client profiles from given sources | ||
| #[unsafe(no_mangle)] | ||
| pub extern "C" fn temporal_core_client_config_load( |
There was a problem hiding this comment.
Was reviewing .NET and noticed - this doesn't need to be async w/ a callback. Can just return the result or failure. Can see calls like temporal_core_runtime_new or temporal_core_worker_new to see how they return success or fail.
What was changed
C bridge code for .NET env config
Part of [Feature Request] Environment Configuration sdk-dotnet#490
How was this tested:
Integration tests lang-side
Any docs updates needed?
No