[SCAL-271343] Give correct value to the Iterative Change analysis Action enum #304
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @midhun-kr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a data inconsistency by updating a specific enum value within the SDK. The change aligns the SDK's definition with a recent fix implemented in a related package, ensuring proper functionality and data integrity for iterative change analysis actions.
Highlights
- Enum Value Correction: The string value for the
EnableIterativeChangeAnalysisenum member insrc/types.tshas been updated tocontext-menu-item-do-iterative-analysis. This change ensures consistency with a recent modification in theembed-utilpackage, which was part of a bug fix (SCAL-269278).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Code Review
This pull request updates the value of an Action enum member to fix a bug. The change is correct and aligns with the PR's goal. My review includes one suggestion to improve the naming of the enum member for better API clarity and developer experience. This would be a breaking change, so I've also suggested a non-breaking alternative if that's preferred.
commit: |
midhun-kr
force-pushed
the
SCAL-271343
branch
from
927fc8f to
96b891c
Compare
midhun-kr
force-pushed
the
SCAL-271343
branch
from
96b891c to
a4512b0
Compare
|
SonarQube Quality Gate
|
| * @version SDK: 1.41.0 | ThoughtSpot Cloud: 9.12.0.cl | ||
| */ | ||
| EnableIterativeChangeAnalysis = 'enableIterativeChangeAnalysis', | ||
| IterativeChangeAnalysis = 'context-menu-item-do-iterative-analysis', |
There was a problem hiding this comment.
I changed the enum member name was changed because the action is used to disable or hide as well so Enable prefix does not make sense here . The value was changed as part of the bug fix PR ,https://galaxy.corp.thoughtspot.com/dev/scaligent/pull/41595/files .
There was a problem hiding this comment.
update the sdk minor version.
| * @version SDK: 1.41.0 | ThoughtSpot Cloud: 9.12.0.cl | ||
| */ | ||
| EnableIterativeChangeAnalysis = 'enableIterativeChangeAnalysis', | ||
| IterativeChangeAnalysis = 'context-menu-item-do-iterative-analysis', |
There was a problem hiding this comment.
What about backward compatibility ? This will cause regression.
you need to deprecate the flag and add new action.
There was a problem hiding this comment.
Since the action was added to the SDK only recently, customers were likely not seeing or using the IterativeChangeAnalysis action. If they had been using it, we would have already received reports about the issue. So far, no customer has reported that the Embed action for Iterative CCA is missing. Can we assume this and proceed? Note that these changes were merged only three weeks ago (PR #275
), so it’s possible they have not yet reached customers or been included in the documentation ?
3 participants
As part of the bug (https://thoughtspot.atlassian.net/browse/SCAL-269278) , we have modified the action enum value in embed-util package. So the value in SDK also should be consistent with that
Ref PR : https://galaxy.corp.thoughtspot.com/dev/scaligent/pull/41595