Skip to content

[SCAL-271343] Give correct value to the Iterative Change analysis Action enum #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SCAL-271343] Give correct value to the Iterative Change analysis Action enum #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
* @deprecated Use {@link SAMLRedirect} instead
* @hidden
*/
SAML = 'SSO_SAML',

Check warning on line 60 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Duplicate enum member value SSO_SAML
/**
* SSO using SAML
* Makes the host application redirect to the SAML IdP. Use this
Expand Down Expand Up @@ -102,7 +102,7 @@
* });
* ```
*/
SAMLRedirect = 'SSO_SAML',

Check warning on line 105 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Duplicate enum member value SSO_SAML
/**
* SSO using OIDC
* @hidden
Expand All @@ -114,7 +114,7 @@
* Will make the host application redirect to the OIDC IdP.
* See code samples in {@link SAMLRedirect}.
*/
OIDCRedirect = 'SSO_OIDC',

Check warning on line 117 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Duplicate enum member value SSO_OIDC
/**
* Trusted authentication server
* @hidden
Expand All @@ -138,7 +138,7 @@
* });
* ```
*/
TrustedAuthToken = 'AuthServer',

Check warning on line 141 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Duplicate enum member value AuthServer
/**
* Trusted authentication server Cookieless, Use your own authentication
* server which returns a bearer token, generated using the `secret_key`
Expand Down Expand Up @@ -1094,7 +1094,7 @@
* Hide list page columns
* For example: hiddenListColumns = [ListPageColumns.Author]
*
* **Note**: This option is currently available only in full app embedding and requires importing the ListPageColumns enum.

Check warning on line 1097 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Comments may not exceed 90 characters
* At present, it can be used with Liveboard and Answer list pages, and starting with version 10.14.0.cl, it will also be supported for the Home page.
*
* Supported embed types: `AppEmbed`
Expand Down Expand Up @@ -1432,7 +1432,7 @@
/**
* This flag is used to enable/disable hide irrelevant filters in Liveboard tab
*
* **Note**: This feature is supported only if compact header is enabled on your Liveboard. To enable compact header, use the `isLiveboardCompactHeaderEnabled` attribute.

Check warning on line 1435 in src/types.ts

View workflow job for this annotation

GitHub Actions / build 

Comments may not exceed 90 characters
*
* Supported embed types: `AppEmbed`, `LiveboardEmbed`
* @version SDK: 1.36.0 | ThoughtSpot:10.6.0.cl
Expand Down Expand Up @@ -5188,16 +5188,16 @@
*/
EnableContextualChangeAnalysis = 'enableContextualChangeAnalysis',
/**
* Action ID to hide or disable Iterative Change Analysis option
* Action ID to hide, disable or show Iterative Change Analysis option
* on contextual change analysis Inisght charts context menu
*
* @example
* ```js
* disabledActions: [Action.EnableIterativeChangeAnalysis]
* disabledActions: [Action.IterativeChangeAnalysis]
* ```
* @version SDK: 1.41.0 | ThoughtSpot Cloud: 9.12.0.cl
*/
EnableIterativeChangeAnalysis = 'enableIterativeChangeAnalysis',
IterativeChangeAnalysis = 'context-menu-item-do-iterative-analysis',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the enum member name was changed because the action is used to disable or hide as well so Enable prefix does not make sense here . The value was changed as part of the bug fix PR ,https://galaxy.corp.thoughtspot.com/dev/scaligent/pull/41595/files .

Copy link
Contributor

@ruchI9897 ruchI9897 Sep 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the sdk minor version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about backward compatibility ? This will cause regression.
you need to deprecate the flag and add new action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the action was added to the SDK only recently, customers were likely not seeing or using the IterativeChangeAnalysis action. If they had been using it, we would have already received reports about the issue. So far, no customer has reported that the Embed action for Iterative CCA is missing. Can we assume this and proceed? Note that these changes were merged only three weeks ago (PR #275
), so it’s possible they have not yet reached customers or been included in the documentation ?

/**
* Action ID to hide or disable Natural Language Search query.
*
Expand Down
Loading
Loading