Get version working; Code clean up #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way pulled in an unneeded dependency and didn't even work. Signed-off-by: Jacob Weinstock <[email protected]>
Remove unused goals/targets and associated files and directories. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Neither of these are used or needed. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
clean-ups
branch
from
8605bfd to
299731b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements version information functionality and performs code cleanup by removing unused scripts and dependencies. The main goals are to get version population working with a custom build package and simplify the build process by removing complex versioning scripts.
- Implements custom version handling using Go module pseudo-version parsing
- Removes numerous unused build scripts and boilerplate checking tools
- Updates dependencies by removing unused imports and tools
- Simplifies the build system by removing complex LDFLAGS generation
Reviewed Changes
Copilot reviewed 31 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/build/build.go | New package implementing pseudo-version parsing for Git revision information |
| pkg/build/build_test.go | Comprehensive test suite for the new build package functionality |
| main.go | Updates version logging to use new build.GitRevision() instead of k8s component-base |
| tools.go | Removes unused tool dependencies (ginkgo, kustomize) |
| go.mod | Removes dependencies no longer needed after tool cleanup |
| Makefile | Simplifies build process by removing complex versioning and unused tool management |
| templates/cluster-template.yaml | Updates kube-vip container version from v0.6.4 to v0.9.2 |
| Multiple hack/ files | Removes unused build scripts, boilerplate checking, and related tooling |
| .github/workflows/ | Updates CI/CD to use simplified build process without custom LDFLAGS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Aug 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gets the version population working. Additionally, removes a lot of unused code and simplifies other parts.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: