Apply dynamic filter again for individual events #3392
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the `event_enabled` is not yet implemented on `EnvFilter`. It has created issues that dynamic filters are effectively ignored, when this filter is composed with another layer through `with_filter` combinator. Related to rust-lang/rust#147613 Signed-off-by: Xiangfei Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It turns out that the
event_enabledis not yet implemented onEnvFilter.It has created issues that dynamic filters are effectively ignored, when this filter is composed with another layer through
with_filtercombinator.Related to rust-lang/rust#147613, which is deployed to mitigate the issue arising from the missing filter predicate. This patch will allow the compiler to use the filter in a more idiomatic way.
Solution
In this
event_enabledpredicate, we apply the dynamic filters once again per event properly this time inEnvFilter.