Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion tracing-subscriber/src/filter/env/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use tracing_core::{
field::Field,
span,
subscriber::{Interest, Subscriber},
Metadata,
Event, Metadata,
};

/// A [`Layer`] which filters spans and events based on a set of filter
Expand Down Expand Up @@ -539,6 +539,30 @@ impl EnvFilter {
false
}

fn event_enabled<S>(&self, event: &Event<'_>, _: &Context<'_, S>) -> bool {
let metadata = event.metadata();
let &level = metadata.level();
if self.has_dynamics && self.dynamics.max_level >= level {
// We test against callsite one more time for the event
let enabled_by_cs = self
.by_cs
.read()
.ok()
.map_or(false, |by_cs| by_cs.contains_key(&metadata.callsite()));
if enabled_by_cs {
return true;
}

let scope = self.scope.get_or_default().borrow();
if scope.is_empty() {
return false;
}
return scope.iter().any(|&filter| filter >= level);
}
// Somehow the event hits here even though static checks should filter it out?
false
}

/// Returns an optional hint of the highest [verbosity level][level] that
/// this `EnvFilter` will enable.
///
Expand Down Expand Up @@ -711,6 +735,10 @@ feature! {
self.enabled(meta, ctx.clone())
}

fn event_enabled(&self, event: &Event<'_>, cx: &Context<'_, S>) -> bool {
self.event_enabled(event, cx)
}

#[inline]
fn callsite_enabled(&self, meta: &'static Metadata<'static>) -> Interest {
self.register_callsite(meta)
Expand Down