fix(expo): check for config values before adding #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates AndroidManifest/Info.plist config values adding in the Expo plugin to first check if the relevant URL schemes are already present. If so, they are skipped.
There was a problem hiding this comment.
Pull request overview
This PR fixes the Expo plugin to prevent duplicate URL schemes from being added to both AndroidManifest.xml and Info.plist configuration files. The plugin now checks if schemes already exist before adding them.
- Replaced the
concatapproach with aforEachloop that checks for existing schemes before adding new ones - Added defensive checks for both Android intents and iOS schemes to prevent duplicates
- Fixed the return statement placement for the
withInfoPlistplugin
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates AndroidManifest/Info.plist config values adding in the Expo plugin to first check if the relevant URL schemes are already present. If so, they are skipped.
@LeumitApp and @cmaurel-cgi – this should solve the problem you reported, would you be able to check if this works for you? I don't currently have an Expo app set up that I can easily test with.
Fixes #319