Skip to content

fix(expo): check for config values before adding #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(expo): check for config values before adding #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions app.plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,36 @@ const intents = ['geo', 'waze'].map((app) => {
* @type {import('@expo/config-plugins').ConfigPlugin}
*/
module.exports = function withReactNativeMapLink(config) {
// eslint-disable-next-line no-shadow
config = withAndroidManifest(config, async (config) => {
let intent = config.modResults.manifest.queries[0].intent ?? [];
// @ts-expect-error unnecessary type gymnastics
config.modResults.manifest.queries[0].intent = intent.concat(intents);
intents.forEach((newIntent) => {
const newScheme = newIntent.data.$['android:scheme'];
const existing = intent.some((intentItem) => {
const existingScheme =
intentItem.data?.[0]?.$?.['android:scheme'] ||
intentItem.data?.$?.['android:scheme'];
return existingScheme === newScheme;
});
if (!existing) {
intent.push(newIntent);
}
});

config.modResults.manifest.queries[0].intent = intent;
return config;
});

// eslint-disable-next-line no-shadow
return withInfoPlist(config, (config) => {
config.modResults.LSApplicationQueriesSchemes =
config.modResults.LSApplicationQueriesSchemes?.concat(schemes) ?? schemes;
config = withInfoPlist(config, (config) => {
const existing = config.modResults.LSApplicationQueriesSchemes ?? [];
schemes.forEach((scheme) => {
if (!existing.includes(scheme)) {
existing.push(scheme);
}
});

config.modResults.LSApplicationQueriesSchemes = existing;
return config;
});

return config;
};
Loading