Skip to content

Conversation

@web-padawan
Copy link
Contributor

Some improvements to the current V24 based implementation before V25 preparations:

  • Changed to use Lit template for rendering slotted vaadin-text-field
    • This is also how we do it nowadays e.g. in vaadin-login-form etc
  • Changed to use SlotStylesMixin for applying styles to that text-field
    • The mixin exists specifically for such cases (managing <style> tags)
  • Changed to use order CSS property for placing toggle button at the end
    • Removed hack using MutationObserver and <slot> flex direction
  • Changed to set ARIA attributes on the actual slotted <input> element

@web-padawan web-padawan requested a review from paodb October 22, 2025 13:02
@web-padawan
Copy link
Contributor Author

Closing in favor of #13 - let's proceed with a single PR for V25 upgrade.

@web-padawan web-padawan deleted the refactor/simplify-render branch October 28, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants