fix: use base64url encoding to prevent esbuild ?source= corruption #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base64-encoded CSS data in virtual file paths as the source query parameter can contain `/` and `//` characters, which are susceptible to path normalization in bundler plugin systems. While the source parameter should be opaque it is not URL safe and esbuild configurations can collapse `//` → `/`, which corrupts the base64 data preventing compressed source data from being read. Switching to base64url encoding replaces `/` with `_` and `+` with `-`, making the encoded data safe for use in file paths and resilient to this class of error.
🦋 Changeset detectedLatest commit: a674f56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
We encountered this in production using @vanilla-extract/esbuild-plugin with a CSS file where gzip+base64 produced
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64-encoded CSS data in virtual file paths as the source query parameter can contain
/and//characters, which are susceptible to path normalization in bundler plugin systems. While the source parameter should be opaque it is not URL safe and esbuild configurations can collapse//→/, which corrupts the base64 data preventing compressed source data from being read.Switching to base64url encoding replaces
/with_and+with-, making the encoded data safe for use in file paths and resilient to this class of error.