Skip to content

fix: use base64url encoding to prevent esbuild ?source= corruption #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: use base64url encoding to prevent esbuild ?source= corruption #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f6735
fix: use base64url encoding to prevent path normalization corruption
sallustfire Nov 9, 2025
a674f56
add changeset
sallustfire Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-lamps-complain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@vanilla-extract/integration': patch
---

base64url encode generated CSS source to avoid errors in virtual file paths
8 changes: 4 additions & 4 deletions packages/integration/src/serialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ export async function serializeCss(source: string): Promise<string> {
if (source.length > compressionThreshold) {
const compressedSource = await zip(source);

return compressionFlag + compressedSource.toString('base64');
return compressionFlag + compressedSource.toString('base64url');
}

return Buffer.from(source, 'utf-8').toString('base64');
return Buffer.from(source, 'utf-8').toString('base64url');
}

export async function deserializeCss(source: string): Promise<string> {
if (source.indexOf(compressionFlag) > -1) {
const decompressedSource = await unzip(
Buffer.from(source.replace(compressionFlag, ''), 'base64'),
Buffer.from(source.replace(compressionFlag, ''), 'base64url'),
);

return decompressedSource.toString('utf-8');
}

return Buffer.from(source, 'base64').toString('utf-8');
return Buffer.from(source, 'base64url').toString('utf-8');
}