[ROCm] Update Triton, Torch, and AITER branches for ROCm base Dockerfile #27206
Conversation
Signed-off-by: Micah Williamson <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pinned commit hashes for Triton, PyTorch, and AITER dependencies in the ROCm base Dockerfile. While pinning dependencies to specific commits is great for reproducibility, using raw commit hashes without any context makes it difficult to track versions. I've added comments suggesting to add the corresponding version/tag for each updated dependency to improve maintainability. This is important for debugging, security audits, and general understanding of the build environment.
| @@ -1,13 +1,13 @@ | |||
| ARG BASE_IMAGE=rocm/dev-ubuntu-22.04:7.0-complete | |||
| ARG TRITON_BRANCH="f9e5bf54" | |||
| ARG TRITON_BRANCH="57c693b6" | |||
There was a problem hiding this comment.
For improved maintainability and easier version tracking, it's a good practice to add a comment next to the commit hash indicating the corresponding tag or version of Triton. This helps in quickly identifying the version being used, which is important for debugging and security vulnerability assessments.
ARG TRITON_BRANCH="57c693b6" # TODO: Add Triton version/tag
| ARG TRITON_BRANCH="57c693b6" | ||
| ARG TRITON_REPO="https://github.com/ROCm/triton.git" | ||
| ARG PYTORCH_BRANCH="b2fb6885" | ||
| ARG PYTORCH_BRANCH="1c57644d" |
There was a problem hiding this comment.
Similar to the Triton branch, please add a comment here to specify the PyTorch version or tag that this commit hash corresponds to. This will improve the Dockerfile's maintainability and make dependency tracking more straightforward.
ARG PYTORCH_BRANCH="1c57644d" # TODO: Add PyTorch version/tag
| ARG FA_BRANCH="0e60e394" | ||
| ARG FA_REPO="https://github.com/Dao-AILab/flash-attention.git" | ||
| ARG AITER_BRANCH="2ab9f4cd" | ||
| ARG AITER_BRANCH="eef23c7f" |
There was a problem hiding this comment.
Please add a comment to indicate the AITER version or tag for this commit hash. Explicitly documenting the version improves maintainability and helps with auditing dependencies for security or compatibility reasons.
ARG AITER_BRANCH="eef23c7f" # TODO: Add AITER version/tag
|
To add to the background. The change adjusts the base versions to the next official rocm/vllm docker release, as well as rocm/vllm-dev:base image as of 10/20 |
…ile (vllm-project#27206) Signed-off-by: Micah Williamson <[email protected]>
…ile (vllm-project#27206) Signed-off-by: Micah Williamson <[email protected]> Signed-off-by: sstamenk <[email protected]>
…ile (vllm-project#27206) Signed-off-by: Micah Williamson <[email protected]>
…ile (vllm-project#27206) Signed-off-by: Micah Williamson <[email protected]> Signed-off-by: Alberto Perdomo <[email protected]>
2 participants
Update default Triton, Torch, and AITER branches for ROCm