Skip to content

[ROCm] Update Triton, Torch, and AITER branches for ROCm base Dockerfile #27206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

[ROCm] Update Triton, Torch, and AITER branches for ROCm base Dockerfile #27206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker/Dockerfile.rocm_base
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ARG BASE_IMAGE=rocm/dev-ubuntu-22.04:7.0-complete
ARG TRITON_BRANCH="f9e5bf54"
ARG TRITON_BRANCH="57c693b6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For improved maintainability and easier version tracking, it's a good practice to add a comment next to the commit hash indicating the corresponding tag or version of Triton. This helps in quickly identifying the version being used, which is important for debugging and security vulnerability assessments.

ARG TRITON_BRANCH="57c693b6" # TODO: Add Triton version/tag

ARG TRITON_REPO="https://github.com/ROCm/triton.git"
ARG PYTORCH_BRANCH="b2fb6885"
ARG PYTORCH_BRANCH="1c57644d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the Triton branch, please add a comment here to specify the PyTorch version or tag that this commit hash corresponds to. This will improve the Dockerfile's maintainability and make dependency tracking more straightforward.

ARG PYTORCH_BRANCH="1c57644d" # TODO: Add PyTorch version/tag

ARG PYTORCH_VISION_BRANCH="v0.23.0"
ARG PYTORCH_REPO="https://github.com/ROCm/pytorch.git"
ARG PYTORCH_VISION_REPO="https://github.com/pytorch/vision.git"
ARG FA_BRANCH="0e60e394"
ARG FA_REPO="https://github.com/Dao-AILab/flash-attention.git"
ARG AITER_BRANCH="2ab9f4cd"
ARG AITER_BRANCH="eef23c7f"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Please add a comment to indicate the AITER version or tag for this commit hash. Explicitly documenting the version improves maintainability and helps with auditing dependencies for security or compatibility reasons.

ARG AITER_BRANCH="eef23c7f" # TODO: Add AITER version/tag

ARG AITER_REPO="https://github.com/ROCm/aiter.git"

FROM ${BASE_IMAGE} AS base
Expand Down