-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add prettier as a default formatter #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried to keep config as close as possible to current code style, while code has minimal changes, tests were in not a good state, so many changes there. |
Also, my company will be supporting this project, so I can spend some of my work time on this project. |
@smokhov If you have time to review new config and provide any feedback that would be great. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good to me.
- Add config - Add npm script to check and reformat code - Add format check step to GitLab PR pipeline - Reformat all files
d3caa7a
to
8f34a88
Compare
Closes #1352