perf: Update swc and switch to wasmtime #11303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
team
quininer
force-pushed
the
o/wasmtime
branch
2 times, most recently
from
06c805f to
2163d74
Compare
📦 Binary Size-limit
🎉 Size decreased by 2.76MB from 50.38MB to 47.62MB (⬇️5.48%) |
quininer
force-pushed
the
o/wasmtime
branch
3 times, most recently
from
ddde9ab to
9de33dc
Compare
CodSpeed Performance ReportMerging #11303 will not alter performanceComparing 🎉 Hooray!
|
quininer
force-pushed
the
o/wasmtime
branch
2 times, most recently
from
f201f0e to
76d0202
Compare
|
📝 Benchmark detail: Open
Threshold exceeded: ["10000_big_production-mode_disable-minimize + exec","10000_development-mode + exec","10000_production-mode + exec","10000_production-mode_persistent-cold + exec","large-dyn-imports_development-mode + exec","large-dyn-imports_production-mode + exec","10000_development-mode + rss memory","10000_development-mode_hmr + rss memory","10000_production-mode + rss memory","10000_production-mode_persistent-cold + rss memory","arco-pro_development-mode_hmr + rss memory"] |
|
📝 Benchmark detail: Open
Threshold exceeded: ["10000_big_production-mode_disable-minimize + exec","10000_development-mode + exec","10000_production-mode + exec","10000_production-mode_persistent-cold + exec","large-dyn-imports_development-mode + exec","large-dyn-imports_production-mode + exec","10000_development-mode + rss memory","10000_development-mode_hmr + rss memory","10000_production-mode + rss memory","10000_production-mode_persistent-cold + rss memory","arco-pro_development-mode + rss memory","arco-pro_development-mode_hmr + rss memory"] |
kdy1
pushed a commit
to swc-project/swc
that referenced
this pull request
Aug 6, 2025
) **Description:** Currently, `wasmtime-wasi` uses tokio `block_on` internally, which causes panic when used in the tokio runtime. I originally thought this could be solved by use `block_in_place`, but the large scope of `block_in_place` caused a serious performance regression (even without use plugin). see web-infra-dev/rspack#11303 (comment) Switch to `wasi-common` is a better choice, which simplifies the wasi implment and makes it independent of tokio.
|
📝 Benchmark detail: Open
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates SWC dependencies and switches the WebAssembly runtime from wasmer to wasmtime for plugin execution. The update brings SWC from version 33.0.0 to 35.0.0 and introduces wasmtime as the new WASM runtime backend.
Key changes include:
- Update SWC core and related dependencies to version 35.0.0
- Replace wasmer-based plugin runtime with wasmtime implementation
- Clean up dependency allowlist in deny.toml by removing unused crates
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_workspace/src/generated.rs | Updates SWC version constant from 33.0.0 to 35.0.0 |
| crates/rspack_util/src/swc/runtime.rs | Adds new wasmtime-based plugin runtime implementation |
| crates/rspack_util/src/swc.rs | Exposes the new runtime module under plugin feature flag |
| crates/rspack_util/Cargo.toml | Adds wasmtime and related dependencies for plugin feature |
| crates/rspack_loader_swc/src/lib.rs | Integrates wasmtime runtime into SWC loader configuration |
| crates/rspack_loader_swc/Cargo.toml | Updates plugin feature dependencies to use wasmtime |
| crates/rspack_binding_api/src/swc.rs | Integrates wasmtime runtime into binding API |
| crates/rspack_binding_api/Cargo.toml | Adds rspack_util plugin feature dependency |
| Cargo.toml | Updates SWC package versions and adds wasmtime dependencies |
| deny.toml | Removes unused dependency allowlist entries |
| packages/rspack-test-tools/tests/watchCases/build-chunk-graph/runtime-chunk-recover-error/1/errors.js | Updates expected error messages for new parser |
ahabhgk
approved these changes
Aug 7, 2025
|
Could you add a PR description? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the swc version to
35.0.0and switch the swc plugin runner backend from wasmer to wasmtime.Related links
wasmtimebackend swc-project/swc#10958Checklist