Skip to content

Conversation

@ramiy
Copy link
Contributor

@ramiy ramiy commented Sep 5, 2025

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 5, 2025
@captainbrosset
Copy link
Contributor

Can you please also generate the dist file by running npm install and then npm run dist features/custom-media-queries.yml?
Thank you.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. Some suggestions to get this into a mergeable condition. Thank you!

@@ -0,0 +1,5 @@
name: Custom media queries
description: The `@custom-media` rule defines a named media query, which can then be reused in multiple `@media` rules.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky suggestions to follow our guidelines around defines/sets/etc. and passive constructions. Also, I thought it would be nice to mention CSS here, like we do for other at-rules.

Suggested change
description: The `@custom-media` rule defines a named media query, which can then be reused in multiple `@media` rules.
description: The `@custom-media` CSS at-rule names a media query, which you can reuse in multiple `@media` rules.

description: The `@custom-media` rule defines a named media query, which can then be reused in multiple `@media` rules.
spec: https://www.w3.org/TR/mediaqueries-5/#custom-mq
group: media-queries
# Custom media queries are not in BCD. So, there are no BCD keys we can list here yet.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment here with predicted BCD keys would be nice. Like this:

Suggested change
# Custom media queries are not in BCD. So, there are no BCD keys we can list here yet.
# Not in BCD yet, but expecting something like:
# - css.at-rules.custom-media
# - api.CSSCustomMediaRule
# - api.CSSCustomMediaRule.name
# - api.CSSCustomMediaRule.query

@@ -0,0 +1,5 @@
name: Custom media queries
description: The `@custom-media` rule defines a named media query, which can then be reused in multiple `@media` rules.
spec: https://www.w3.org/TR/mediaqueries-5/#custom-mq
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass tests:

Suggested change
spec: https://www.w3.org/TR/mediaqueries-5/#custom-mq
spec: https://drafts.csswg.org/mediaqueries-5/#custom-mq

name: Custom media queries
description: The `@custom-media` rule defines a named media query, which can then be reused in multiple `@media` rules.
spec: https://www.w3.org/TR/mediaqueries-5/#custom-mq
group: media-queries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since nobody has shipped this (yet), you need a status block, like this:

Suggested change
group: media-queries
group: media-queries
status:
baseline: false
support: {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants