-
Notifications
You must be signed in to change notification settings - Fork 195
Add Custom Media Queries #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Custom Media Queries #3325
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
37e5389
Add Custom Media Queries
ramiy f80a775
Update
ramiy 667976a
Update
ramiy 05c2b73
Add status
ramiy cd12fa1
Merge branch 'main' into patch-2
ramiy 16b1c67
Add support
ramiy 238df97
Update spec
ramiy bec7d8b
Merge branch 'main' into patch-2
captainbrosset e2cbe44
Update features/custom-media-queries.yml
ramiy 8731daa
Update features/custom-media-queries.yml
ramiy c47d03d
Update
ramiy 8444e35
Merge branch 'main' into patch-2
ramiy a29dea8
Apply suggestion from @captainbrosset
ramiy 22f2070
Merge branch 'main' into patch-2
ramiy 2c6d62f
Apply suggestion from @ddbeck
ramiy 95b2562
Apply suggestion from @ddbeck
ramiy 985fba2
Apply suggestion from @ddbeck
ramiy a45ab86
Apply suggestion from @ddbeck
ramiy 86f1257
Merge branch 'main' into patch-2
ramiy 8a0789c
Simplify status setting for custom-media-queries
ddbeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| name: Custom media queries | ||
| description: The `@custom-media` CSS at-rule names a media query, which you can reuse in multiple `@media` rules. | ||
| spec: https://drafts.csswg.org/mediaqueries-5/#custom-mq | ||
| group: media-queries | ||
| # Not in BCD yet, but expecting something like: | ||
| # - css.at-rules.custom-media | ||
| # - api.CSSCustomMediaRule | ||
| # - api.CSSCustomMediaRule.name | ||
| # - api.CSSCustomMediaRule.query | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Generated from: custom-media-queries.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.