-
Notifications
You must be signed in to change notification settings - Fork 133
[Woo POS][Local Catalog] Full sync overdue warning banner #14704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: woomob-1412-woo-poslocal-catalog-full-sync-overdue-handling
Are you sure you want to change the base?
[Woo POS][Local Catalog] Full sync overdue warning banner #14704
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…ling' into woomob-1412-full-sync-overdue-warning
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## woomob-1412-woo-poslocal-catalog-full-sync-overdue-handling #14704 +/- ##
=================================================================================================
- Coverage 38.37% 38.36% -0.02%
Complexity 9843 9843
=================================================================================================
Files 2096 2097 +1
Lines 116960 117012 +52
Branches 15659 15668 +9
=================================================================================================
+ Hits 44886 44894 +8
- Misses 67908 67950 +42
- Partials 4166 4168 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a warning banner to notify users when the product catalog hasn't been synced in the last 7 days, helping ensure the POS system has up-to-date product information.
- Adds a new banner component displayed above the item list when full sync is overdue
- Integrates sync status checking logic into the items view model
- Updates layout spacing across item screens to accommodate the banner
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
WooPosItemsViewModel.kt | Adds sync status checking and banner state management |
WooPosRefreshCatalogBanner.kt | Creates the warning banner component with animation |
WooPosItemsScreen.kt | Integrates banner into main items screen layout |
WooPosItemsUIEvent.kt | Adds banner dismissal event |
strings.xml | Adds banner text strings |
ic_woo_pos_info_banner.xml | Adds info icon for the banner |
Test files | Updates test setup with new dependencies |
Screen files | Removes top padding to accommodate banner spacing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/coupons/WooPosCouponsScreen.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/coupons/WooPosCouponsScreen.kt
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosRefreshCatalogBanner.kt
Outdated
Show resolved
Hide resolved
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt
Outdated
Show resolved
Hide resolved
…ling' into woomob-1412-full-sync-overdue-warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I've left a few np suggestions.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt
Outdated
Show resolved
Hide resolved
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt
Outdated
Show resolved
Hide resolved
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosRefreshCatalogBanner.kt
Outdated
Show resolved
Hide resolved
Version |
2b86b01
to
929e1d7
Compare
Full sync overdue – warning banner
WOOMOB-1412
trunk
Description
This PR adds warning banner shown above item list in case of full sync overdue.
Steps to reproduce
Adjust the sync overdue treshold to make the warning banner visible on the top of the items list in POS.
Testing information
The tests that have been performed
Above
Images/gif
Screen_recording_20251007_171141.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.