Skip to content

Conversation

samiuelson
Copy link
Contributor

@samiuelson samiuelson commented Oct 6, 2025

Full sync overdue – warning banner

WOOMOB-1412

⚠️ Do not merge until the parent branch is trunk

Description

This PR adds warning banner shown above item list in case of full sync overdue.

Steps to reproduce

Adjust the sync overdue treshold to make the warning banner visible on the top of the items list in POS.

Testing information

  • Verify that the warning banner looks good.
  • Verify that the warning banner can be dismissed.

The tests that have been performed

Above

Images/gif

Screen_recording_20251007_171141.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 6, 2025

1 Error
🚫 This PR is tagged with status: do not merge label(s).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc2db87c
Direct Downloadwoocommerce-wear-prototype-build-pr14704-c2db87c.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc2db87c
Direct Downloadwoocommerce-prototype-build-pr14704-c2db87c.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 21.15385% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.36%. Comparing base (f0ad8bf) to head (a21e81d).

Files with missing lines Patch % Lines
...ui/woopos/home/items/WooPosRefreshCatalogBanner.kt 0.00% 39 Missing ⚠️
...droid/ui/woopos/home/items/WooPosItemsViewModel.kt 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                        @@
##             woomob-1412-woo-poslocal-catalog-full-sync-overdue-handling   #14704      +/-   ##
=================================================================================================
- Coverage                                                          38.37%   38.36%   -0.02%     
  Complexity                                                          9843     9843              
=================================================================================================
  Files                                                               2096     2097       +1     
  Lines                                                             116960   117012      +52     
  Branches                                                           15659    15668       +9     
=================================================================================================
+ Hits                                                               44886    44894       +8     
- Misses                                                             67908    67950      +42     
- Partials                                                            4166     4168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samiuelson samiuelson added the type: task An internally driven task. label Oct 7, 2025
@samiuelson samiuelson added this to the 23.5 milestone Oct 7, 2025
@samiuelson samiuelson requested a review from Copilot October 7, 2025 15:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning banner to notify users when the product catalog hasn't been synced in the last 7 days, helping ensure the POS system has up-to-date product information.

  • Adds a new banner component displayed above the item list when full sync is overdue
  • Integrates sync status checking logic into the items view model
  • Updates layout spacing across item screens to accommodate the banner

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
WooPosItemsViewModel.kt Adds sync status checking and banner state management
WooPosRefreshCatalogBanner.kt Creates the warning banner component with animation
WooPosItemsScreen.kt Integrates banner into main items screen layout
WooPosItemsUIEvent.kt Adds banner dismissal event
strings.xml Adds banner text strings
ic_woo_pos_info_banner.xml Adds info icon for the banner
Test files Updates test setup with new dependencies
Screen files Removes top padding to accommodate banner spacing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@samiuelson samiuelson requested a review from malinajirka October 7, 2025 16:37
@samiuelson samiuelson added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 7, 2025
@samiuelson samiuelson marked this pull request as ready for review October 7, 2025 16:38
@malinajirka malinajirka self-assigned this Oct 8, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I've left a few np suggestions.

@wpmobilebot wpmobilebot modified the milestones: 23.5, 23.6 Oct 17, 2025
@wpmobilebot
Copy link
Collaborator

Version 23.5 has now entered code-freeze, so the milestone of this PR has been updated to 23.6.

@samiuelson samiuelson requested a review from a team as a code owner October 17, 2025 15:07
@samiuelson samiuelson removed the request for review from a team October 17, 2025 15:07
@samiuelson samiuelson marked this pull request as draft October 17, 2025 15:14
@samiuelson samiuelson force-pushed the woomob-1412-full-sync-overdue-warning branch from 2b86b01 to 929e1d7 Compare October 17, 2025 15:15
@samiuelson samiuelson marked this pull request as ready for review October 17, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: do not merge Dependent on another PR, ready for review but not ready for merge. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants