Require 'static lifetime for CompletionModel #1049
Conversation
Added 'static lifetime requirement to CompletionModel.Adds a 'static bound to the CompletionClient::CompletionModel associated type so implementations can be turned into trait objects (Box/Arc<dyn ...>)
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
Only one change required then lgtm
| pub trait CompletionClient: ProviderClient + Clone { | ||
| /// The type of CompletionModel used by the client. | ||
| type CompletionModel: CompletionModel; | ||
| // require the associated CompletionModel to be 'static so it can be used |
There was a problem hiding this comment.
Please use the original docstring here and move this detail to the trait docstrings rather than having it here
|
I mean we already have CompletionClientDyn for this, unless you want to get rid of the dyn version @joshua-mo-143 I would probably not impose that constraint on the trait. |
Ah, yeah - completely forgot about that. @Rishirandhawa Is there any specific reason why you need this specific change rather than CompletionClientDyn? |
|
Closing in the interest of repo hygiene since there's no response and there was no prior discussion. |
3 participants
Adds a 'static bound to the CompletionClient::CompletionModel associated type so implementations can be turned into trait objects (Box/Arc<dyn ...>). This addresses compiler lifetime/bound errors when converting CompletionModels into dynamic trait objects for CompletionClientDyn/AgentBuilder.
Notes: Most provider implementations already satisfy this because they bound their inner generic HTTP client with 'static