feat(rig-951): generic HTTP client #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -0,0 +1,203 @@ | |||
| use crate::{ | |||
There was a problem hiding this comment.
is this file needed? seems to be an old artifact from the chatbot PR
There was a problem hiding this comment.
Didn't catch that, will remove
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got this all worked out now that I'm using types from the
httpcrate, and using return-position impls in trait methods vs theasynckeyword to enforceSendreturn types, but I figured I'd still put it up here.Not sure that
Bytesis the right type to bound request and response bodies by. For instance,Stringdoes notimpl From<Bytes>so it's sort of a pain to get the text out of a response. TheArcoverhead is less than ideal as well. Same with the error handling, we have aBox<dyn Error>which I think is generally suboptimal.But it is, at the very least, typechecking for the anthropic provider