Windows follow-ups: app icon, working update checks, settings fixes, docs

[davidbudnick]

Summary

Windows follow-ups from daily-driving the v0.6.19 MSI on Windows 11: the missing app icon, the always-failing update check, clipped Settings rows, a dead button, and two parity gaps found in a full macOS→Windows feature audit. Five commits, reviewable independently:

1. feat(windows): embed the app icon + version info in both exes

The shipped exes have no resource section at all — Explorer/taskbar/Task Manager show the generic blank-binary icon and the file-properties pane is empty. A build-time-generated .rc (icon + VERSIONINFO tracking CARGO_PKG_VERSION) is compiled with embed-resource, pinned to the exact version already in Cargo.lock as gpui's own build-dep — the resolve adds an edge, not a crate, and the pinned gpui rev cannot move (verified: the lock diff is +2 dep-edge lines). New design/icon/openlogi.ico (16–256 px, PNG-compressed entries, rendered from design/icon/openlogi.png); the MSI gets ARPPRODUCTICON via a <?ifndef?> preprocessor default resolved relative to the .wxs ($(sys.SOURCEFILEDIR)), so the release workflow needs no new define.

2. feat(updater): publish Windows assets in latest.json; notify-only checks on Windows

This is #347 "PR 4", scoped to what's safe today. On Windows every check fails with "no release asset matched the current platform (windows/x86_64)" because latest.json is dmg-only and the client asks for format "exe", which no release ships.

• xtask release latest-json now classifies the per-arch Windows .msi/.zip (minisign-required, like the DMGs) into the manifest; .deb/.rpm stay out on purpose (distro package managers own those updates).
• The client requests "msi", so checks resolve on both x86_64 and arm64.

Why notify-only: gpui-updater v0.0.5's Windows install strategy is rename-in-place for a bare .exe and only validates the target extension — handed the MSI the manifest serves, it would rename OpenLogi.exe aside and copy the MSI's bytes over it. INSTALL_SUPPORTED gates auto-install off on Windows, hides the auto-install switch, and turns a found update into a "Download from GitHub" action.

➡️ Companion PR for true one-click updates: AprilNEA/gpui-updater#6 adds the staged msiexec install flow (and fixes the payload-over-exe hazard above). The full macOS-style "Download & Install → Restart to Update" flow on Windows needs that PR merged and tagged first; then OpenLogi bumps the dep and flips INSTALL_SUPPORTED — a two-line follow-up. Until then this PR delivers working checks + notify.

⚠️ One change I could not include: release.yml. GitHub rejects pushes touching workflow files from my CLI token (no workflow scope). To keep the manifest and the R2 bucket from ever disagreeing in the meantime, the Windows manifest entries are gated off by default behind a new --include-windows flag on xtask release latest-json — merging this PR changes the published manifest by exactly nothing. Enabling Windows update checks is then one workflow edit that flips both halves together ("Allow edits by maintainers" is enabled; or apply on merge):

       - name: Generate static updater manifest
         ...
           cargo run -p xtask -- release latest-json \
             --dist dist \
             --tag "$GITHUB_REF_NAME" \
             --base-url "$OPENLOGI_UPDATE_BASE_URL" \
+            --include-windows \
             --output dist/latest.json

       - name: Upload static updater assets to R2
         ...
-          # The Windows binaries' distribution channel is the GitHub Release;
-          # latest.json is still dmg-only, so nothing in the updater bucket
-          # references the zip/msi or their minisigs — keep them all out of
-          # the immutable releases/ prefix until the Windows auto-updater
-          # lands (#347 PR 4). SHA256SUMS still lists them — it describes the
-          # GitHub Release's asset set. *.exe stays excluded defensively even
-          # though no bare exe ships anymore.
+          # latest.json now lists the Windows zip/msi alongside the DMGs
+          # (#347 PR 4), so they and their minisigs belong in the immutable
+          # releases/ prefix the manifest URLs point into. *.exe stays
+          # excluded defensively even though no bare exe ships anymore.
           aws s3 cp dist/ "$release_prefix/" \
             --recursive \
             --exclude latest.json \
             --exclude "*.exe" \
             --exclude "*.exe.minisig" \
-            --exclude "*.zip" \
-            --exclude "*.zip.minisig" \
-            --exclude "*.msi" \
-            --exclude "*.msi.minisig" \
             --cache-control "public, max-age=31536000, immutable" \
             --endpoint-url "$endpoint"

The updater bucket then gains Windows entries on the next tagged release automatically.

3. fix(settings): stop clipping row controls; make the Assets actions visibly work

• Custom rows (Updates hero, update source, About config path, Appearance filter row) built h_flex().justify_between() with a non-shrinking left block — long content, or just Segoe UI being wider than the macOS system font, shoved the trailing button past the window edge (no horizontal scroll exists). Left blocks now flex_1().min_w_0() + truncate(), controls flex_shrink_0() — mirroring what the library's own SettingItem rows already do. Settings widens to 920×640 and aux windows get a window_min_size floor like the main window's.
• Settings → Assets "Open" was silently dead off macOS: open_in_file_manager was #[cfg(target_os = "macos")] with an empty stub elsewhere — even though the macOS arm already used the cross-platform opener crate. The split is gone.
• "Clear"/"Refresh" worked but looked inert: the cache-size blurb is a construction-time snapshot, so the row kept quoting the pre-Clear size until the window reopened. It now recomputes shortly after each manual action.

4. docs(readme): recommend the MSI, explain the portable zip, promote Windows out of preview

The intro/roadmap still said "untested preview" (and advertised a bare .exe that no release ships) even though the README itself records end-to-end validation on Windows 11. Aligned, plus explicit guidance: MSI for most users, zip for portable/no-install.

5. fix(settings): surface the tray toggle on Windows; drop the empty Permissions page

From the parity audit: the Windows notification-area icon honors show_in_menu_bar (tray_windows.rs) but the switch was compiled out as macOS-only — config.toml surgery was the only way to hide the icon. And the Permissions sidebar entry rendered an empty body on Windows (both groups cfg-gated to macOS/Linux; Windows needs no privacy grants for the WH_MOUSE_LL hook or raw HID). The page now registers only where it has content.

Validation checklist

Icon & version info (needs a local/CI Windows build):

• OpenLogi.exe and openlogi-agent.exe show the OpenLogi icon in Explorer, the taskbar, and Task Manager
• Properties → Details shows product/description/version (e.g. "OpenLogi Background Agent", 0.6.19)
• MSI install: Start Menu shortcut and Installed apps entry carry the icon

Updater (client behavior; server side needs the next tagged release):

• Settings → Updates: "Check for Updates" no longer errors with no release asset matched (against a manifest with Windows entries)
• A newer manifest version shows the Update available pill and a Download from GitHub button that opens the releases page
• The "Automatically download and install" switch is absent on Windows, present on macOS
• cargo test -p xtask passes (manifest generator: dmg + msi + zip classification, per-arch, minisign-required)

Settings UI:

• Updates / About / Appearance / Assets pages: no trailing button clipped at the right edge (default window size and after resizing to the minimum)
• The window can't be shrunk below its authored size
• About: a long config path ellipsizes instead of pushing "Show in file manager" off-screen

Assets page:

• "Open" opens the cache folder in Explorer
• "Clear" wipes the cache and the "Downloaded images currently use…" line drops shortly after
• "Refresh" re-downloads device images (size line updates once fetches land)

Parity:

• General page shows "Show in the notification area" on Windows; toggling it and restarting the agent shows/hides the tray icon
• The Permissions sidebar entry is gone on Windows (still present on macOS/Linux)
• Deep-links still land right on Windows: About / Updates menu-and-tray entries open the correct page (index shift)

Follow-ups (out of scope here)

• msiexec install flow in gpui-updater (its Windows README calls the installer flow future work), then flip INSTALL_SUPPORTED
• Windows tray: add Settings / Check-for-Updates items (macOS tray has them via openlogi://, which Windows doesn't register)
• os_version() returns None on Windows — diagnostics reports lack the OS version there

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR improves the Windows release and settings experience. The main changes are:

• Windows icons and version resources for both executables.
• MSI-based update checks with Windows installs kept notify-only.
• Optional Windows entries in the generated updater manifest.
• Settings layout fixes, Windows tray toggle visibility, and asset-folder opening.
• README updates for the supported Windows MSI and portable ZIP paths.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
xtask/src/commands/release/latest_json.rs	Adds Windows MSI and ZIP classification behind an explicit opt-in flag.
crates/openlogi-gui/src/platform/updater.rs	Switches Windows update checks to MSI assets and disables automatic install on Windows.
crates/openlogi-gui/src/windows/settings.rs	Updates Settings sizing and removes the empty Windows Permissions page.

_{Reviews (4): Last reviewed commit: "style: rustfmt" | Re-trigger Greptile}

[davidbudnick]

Confirmed and addressed in 58555d2: the Windows entries are now gated off by default behind --include-windows (with a regression test asserting the default emits a dmg-only manifest). The manifest can no longer reference objects the R2 step doesn't upload — enabling Windows checks is a single release.yml edit that removes the zip/msi excludes and passes the flag, so the two halves move together. The exact diff is in the PR description (workflow files can't be pushed from this fork's token).

[davidbudnick]

Intentional, and the two P1s on this file are each other's mirror: unconditional entries ⇒ the first P1 (manifest URLs the R2 step never uploads); gated entries ⇒ this one (checks stay macOS-only until enabled). Since workflow files can't be pushed from this fork's token, the gate is the only shape where the manifest and the bucket cannot disagree — and Windows clients meanwhile get the correct, honest behavior from this PR anyway: release_format() is fixed to "msi" and the Updates page routes to a "Download from GitHub" action, so nothing is "broken until the workflow enables the flag" beyond what is already true on master (where checks error outright).

Enabling end-to-end Windows checks is the single two-hunk release.yml edit in the PR description — drop the zip/msi excludes from the R2 upload and pass --include-windows to xtask release latest-json — which only the maintainer can commit. Tracked as the remaining slice of #347 "PR 4".

[davidbudnick]

@AprilNEA A few more follow up's to the Windows PR from the other day. Should be able to move it from un-tested to fully supported. Needs an action change, and a PR merged in gpui-updater, lmk if you have any questions. Cheers!