replace AP_GPS::Status and AP_DAL_GPS::Status with AP_GPS_FixType#32501
Open
peterbarker wants to merge 31 commits intoArduPilot:masterfrom
Open
replace AP_GPS::Status and AP_DAL_GPS::Status with AP_GPS_FixType#32501peterbarker wants to merge 31 commits intoArduPilot:masterfrom
peterbarker wants to merge 31 commits intoArduPilot:masterfrom
Conversation
…th AP_GPS_FixType
Contributor
|
Very nice cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have too many enumerations used for this stuff - this gets rid of one of them!
Testing (more checks increases chance of being merged)
Description
We have AP_GPS_FixType which is present even when the AP_GPS library is not. That means you can compile out the AP_GPS header and still have e.g. AP_ADSB still compile.
This is pretty much a no-compiler-output change, except where objects were storing an instance of the enumeration from the mavlink bindings. Since the new thing is only 8 bits wide, there are alignment and machine code instruction changes in the ADSB and ExternalAHRS libraries. Only boards using those libraries are modified