Node interop: Add handling for redirect URI based on platform #7908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
extensions
shylasummers
changed the title
shylasummers
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
jo-arroyo,
lalimasharda,
bgavrilMS,
Robbie-Microsoft and
konstantin-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds platform-specific redirect URI handling to the NativeBrokerPlugin class in msal-node-extensions. The changes implement a new private method that sets different redirect URIs based on the platform (Windows, macOS, or default).
Key changes:
- Adds a new
chooseRedirectUriByPlatformmethod that returns platform-specific redirect URIs - Updates token acquisition methods to use the platform-specific redirect URI
- Removes the msal-node-extensions sample application entirely
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts | Implements platform-specific redirect URI logic in token acquisition methods |
| extensions/msal-node-extensions/test/broker/NativeBrokerPlugin.spec.ts | Adds comprehensive test coverage for new redirect URI functionality across platforms |
| extensions/samples/msal-node-extensions/* | Complete removal of sample application files |
| change/@azure-msal-node-extensions-*.json | Adds changelog entry for the redirect URI feature |
extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts
Outdated
Show resolved
Hide resolved
extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts
Outdated
Show resolved
Hide resolved
konstantin-msft
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the redirect URI in the
NativeBrokerPluginclass based on platform