New tab completions: 1password-cli and herdr - #2395
Open
leventyalcin wants to merge 4 commits into
Open
Conversation
f3aaf30 fixed --tap + --jobs causing bats to declare a test plan it can't fulfil on Linux by forcing TEST_JOBS=1. The macOS job was left on TEST_JOBS=detect with GNU parallel explicitly installed, hitting the same mismatch and exiting with code 1 despite all tests passing. Remove the parallel install step and apply TEST_JOBS=1 unconditionally.
leventyalcin
force-pushed
the
1password-completion
branch
from
August 5, 2026 13:52
4737a3e to
01ab1dd
Compare
seefood
requested changes
Aug 6, 2026
seefood
left a comment
seefood
left a comment
Contributor
There was a problem hiding this comment.
I see here 3 different features in one PR plus a change to the workflows. please break it up and let's do it properly.
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Aug 6, 2026
scop
pushed a commit
to scop/bash-completion
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds bash-it completion wrappers for:
op)herdr)Both tools natively expose
<tool> completion bash, which these wrappers plug into bash-it's completion lifecycle.Why not the standard pattern?
A common completion pattern uses
|| returnas the fallback on binary or existing completion checks, meaning theevalcall is skipped silently when the binary is missing, and things easily go unnoticed.These completions instead check the binary explicitly and stop early with a clear message: No silent failures. Users get an actionable message telling them exactly what didn't
load and where the file lives — without needing to enable full debug mode.
How Has This Been Tested?
Locally installed completions and tested in all scenarios:
All scenarios work as expected.
Screenshots (if appropriate):
https://asciinema.org/a/LiRDH6XnSHEEBxL0
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.