Don't apply animation delay for custom layout #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention: Maybe it's better to just set the animation default to |
chrissainty
approved these changes
Feb 20, 2024
|
@chrissainty Is there a reason this PR is hanging? |
|
Workflow action requires approval to be executed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone uses
UseCustomLayout = true, animations won't be applied.Because the default animation is
ModalAnimationType.FadeInOut, the delay for the animation will be applied also for custom layouts, which leads to a very bad 400ms delay where nothing happens after closing a dialog.