Skip to content

Don't apply animation delay for custom layout #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't apply animation delay for custom layout #558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359265e
Don't apply animation delay for custom layout
0ptim Feb 20, 2024
2c0d150
Merge branch 'main' into main
chrissainty Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Blazored.Modal/BlazoredModalInstance.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ public async Task CloseAsync()
public async Task CloseAsync(ModalResult modalResult)
{
// Fade out the modal, and after that actually remove it
if (AnimationType is ModalAnimationType.FadeInOut)
if (AnimationType is ModalAnimationType.FadeInOut && !UseCustomLayout)
{
OverlayAnimationClass += " fade-out";
StateHasChanged();

await Task.Delay(400); // Needs to be a bit more than the animation time because of delays in the animation being applied between server and client (at least when using blazor server side), I think.
}
else if (AnimationType is ModalAnimationType.PopInOut)
else if (AnimationType is ModalAnimationType.PopInOut && !UseCustomLayout)
{
OverlayAnimationClass += " pop-out";
StateHasChanged();
Expand Down