fix: confirm when enter #2556
Open
fix: confirm when enter #2556
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms3314
requested review from
hayescode,
asvishnyakov and
sandangel
as code owners
dosubot
bot
added
size:S
|
Hi @Ms3314 ! Thanks for looking into this! I can confirm that your code fixes the "complaint" I have about the UX of the New Chat modal popup. It now defaults to Confirm when I hit enter. However, I also notice that Tab-cycling now longer works. Hitting Tab once seems to highlght Cancel, but hitting Enter still confirms the modal and creates a new chat. To be clear: I prefer your change over the current default! I feel it's much more intuitive that enter Confirms, given how prominent the button is. Hope you get a positive review here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before #2525
After
Screen.Recording.2025-09-27.at.3.17.49.PM.mov
mapped the enter key to confirm a new chat