-
Notifications
You must be signed in to change notification settings - Fork 19
[WIP] ND4.1 Fabric Module #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikewiebe
wants to merge
30
commits into
CiscoDevNet:master
Choose a base branch
from
mikewiebe:fabric_module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cisco ND Fabric Management Module
NOTE: This PR is a work in progress [WIP] and is intended to be a starting point for the ND4.1 work the current NDFC team is working on to support creation of modules under the 4.1
manage
andonemanage
buckets. I will be scheduling a call to discuss this work and some of the requirements we would like to ensure are part of each new module in these buckets.This is just a small subset of the existing fabric parameters (Proof of concept) but once we have a chance to sync we will complete the module and use this as a reference module going forward.
Overview
This PR introduces a comprehensive fabric management module for Cisco Nexus Dashboard (ND) with full CRUD operations and state-based configuration management following Ansible best practices.
Key Features Added
New Module:
cisco.nd.manage.fabric
merged
,replaced
,deleted
,overridden
, andquery
statesFabricModel
andFabricManagementModel
for robust data validationCore Functionality
Class Architecture
GetHave
: Retrieves current fabric state from ND APICommon
: Shared utilities for parameter validation and payload constructionMerged
: Implements merge strategy with diff-based updatesReplaced
: Full configuration replacement operationsDeleted
: Fabric deletion with safety checksOverridden
: Combined delete and replace operationsQuery
: Read-only state retrievalConfiguration Support
Technical Improvements
Testing Ready
The module is designed with dependency injection patterns that facilitate comprehensive unit testing and mock-based testing strategies.
This enhancement provides a [POC] foundation for Cisco ND fabric
Sample Module Task