Skip to content

Conversation

Blargian
Copy link
Member

Summary

Checklist

@Blargian Blargian requested a review from a team as a code owner October 17, 2025 12:57
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clickhouse-docs Error Error Comment Oct 17, 2025 1:06pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
clickhouse-docs-jp Ignored Ignored Oct 17, 2025 1:06pm
clickhouse-docs-ru Ignored Ignored Oct 17, 2025 1:06pm
clickhouse-docs-zh Ignored Ignored Oct 17, 2025 1:06pm

@Blargian Blargian changed the title Start generating dictionary functions Functions: start generating dictionary functions Oct 17, 2025
@Blargian Blargian requested a review from Copilot October 17, 2025 12:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces infrastructure for autogenerating documentation for dictionary functions in ClickHouse.

Key changes:

  • Adds "Dictionary" to the list of function categories to be processed
  • Configures source and destination file mappings for dictionary function documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 251 to +252
"Dates and Times"
"Dictionary"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The 'Dictionary' entry is inserted between 'Dates and Times' and 'Encoding', breaking alphabetical ordering. Consider maintaining alphabetical order by placing it after 'Distance' or reorganizing the entire list alphabetically for better maintainability.

Suggested change
"Dates and Times"
"Dictionary"
"Dictionary"
"Dates and Times"

Copilot uses AI. Check for mistakes.

"conditional-functions.md"
"distance-functions.md"
"dates_and_times-functions.md"
"dictionary-functions.md"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The source filename 'dictionary-functions.md' follows the pattern of other entries but is inserted between 'dates_and_times-functions.md' and 'encoding-functions.md'. For consistency and maintainability, consider ordering this list alphabetically or according to the same sequence used in the function categories list.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant