Skip to content

Functions: start generating dictionary functions #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Functions: start generating dictionary functions #4596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/settings/autogenerate-settings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ if [ -f "$FUNCTION_SQL_FILE" ]; then
"Conditional"
"Distance"
"Dates and Times"
"Dictionary"
Comment on lines 251 to +252
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The 'Dictionary' entry is inserted between 'Dates and Times' and 'Encoding', breaking alphabetical ordering. Consider maintaining alphabetical order by placing it after 'Distance' or reorganizing the entire list alphabetically for better maintainability.

Suggested change
"Dates and Times"
"Dictionary"
"Dictionary"
"Dates and Times"

Copilot uses AI. Check for mistakes.

"Encoding"
"Financial"
"Null"
Expand Down Expand Up @@ -364,6 +365,7 @@ insert_src_files=(
"conditional-functions.md"
"distance-functions.md"
"dates_and_times-functions.md"
"dictionary-functions.md"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The source filename 'dictionary-functions.md' follows the pattern of other entries but is inserted between 'dates_and_times-functions.md' and 'encoding-functions.md'. For consistency and maintainability, consider ordering this list alphabetically or according to the same sequence used in the function categories list.

Copilot uses AI. Check for mistakes.

"encoding-functions.md"
"financial-functions.md"
"null-functions.md"
Expand Down Expand Up @@ -395,6 +397,7 @@ insert_dest_files=(
"docs/sql-reference/functions/conditional-functions.md"
"docs/sql-reference/functions/distance-functions.md"
"docs/sql-reference/functions/date-time-functions.md"
"docs/sql-reference/functions/ext-dict-functions.md"
"docs/sql-reference/functions/encoding-functions.md"
"docs/sql-reference/functions/financial-functions.md"
"docs/sql-reference/functions/functions-for-nulls.md"
Expand Down