mctp: don't include linux/mctp.h directly #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e35f4a5 ("mctpd: avoid bitfield & implicit enum values in wire format") introduced a #include <linux/mctp.h> for mctp_eid_t. However, we want the ability to fall-back to the in-tree definitions, so use the internal mctp.h instead. This will use mctp.h if available. Fixes: CodeConstruct#103 Fixes: e35f4a5 ("mctpd: avoid bitfield & implicit enum values in wire format") Signed-off-by: Jeremy Kerr <[email protected]>
We use IFNAMSIZ, so include if.h. Signed-off-by: Jeremy Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e35f4a5 ("mctpd: avoid bitfield & implicit enum values in wire format") introduced a #include <linux/mctp.h> for mctp_eid_t. However, we want the ability to fall-back to the in-tree definitions, so use the internal mctp.h instead. This will use mctp.h if available.
Fixes: #103
Fixes: e35f4a5 ("mctpd: avoid bitfield & implicit enum values in wire format")