Skip to content

Prevent Player Simulator crashes from fake-player dimension transitions (Ex Deorum End Cake interaction)#366

Merged
rubensworks merged 2 commits into
master-1.21-ltsfrom
copilot/fix-player-simulator-crash
May 8, 2026
Merged

Prevent Player Simulator crashes from fake-player dimension transitions (Ex Deorum End Cake interaction)#366
rubensworks merged 2 commits into
master-1.21-ltsfrom
copilot/fix-player-simulator-crash

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

Player Simulator interactions with Ex Deorum End Cake could trigger fake-player dimension transition logic, causing server crashes and client hangs. This PR makes fake-player dimension transitions inert and adds a focused regression test for that path.

  • Fake player hardening

    • ExtendedFakePlayer now overrides dimension transition behavior to no-op.
    • This prevents simulated interactions from invoking cross-dimension player transfer mechanics.
  • Regression coverage

    • Added a new Player Simulator game test to assert ExtendedFakePlayer#changeDimension(...):
      • returns the same fake player instance
      • does not move the fake player to the target dimension
  • Representative change

    @Override
    public @Nullable Entity changeDimension(DimensionTransition transition) {
        return this;
    }

@coveralls
Copy link
Copy Markdown

coveralls commented May 8, 2026

Coverage Report for CI Build 25557915839

Coverage increased (+0.03%) to 71.279%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 13 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

13 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
org/cyclops/integratedtunnels/core/ExtendedFakePlayer.java 13 34.29%

Coverage Stats

Coverage Status
Relevant Lines: 6356
Covered Lines: 5039
Line Coverage: 79.28%
Relevant Branches: 1398
Covered Branches: 488
Branch Coverage: 34.91%
Branches in Coverage %: Yes
Coverage Strength: 4.14 hits per line

💛 - Coveralls

Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedTunnels/sessions/c1ce6f91-f1c7-4e9f-a364-1f79f10d23ac

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix crash when Integrated Tunnels Player Simulator interacts with Ex Deorum End Cake Prevent Player Simulator crashes from fake-player dimension transitions (Ex Deorum End Cake interaction) May 8, 2026
Copilot AI requested a review from rubensworks May 8, 2026 13:26
@rubensworks rubensworks marked this pull request as ready for review May 8, 2026 13:29
@rubensworks rubensworks merged commit 43a536b into master-1.21-lts May 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when Integrated Tunnels Player Simulator interacts with Ex Deorum End Cake

3 participants