Skip to content

Prevent Player Simulator crashes from fake-player dimension transitions (Ex Deorum End Cake interaction) #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 2 commits into from
May 8, 2026
+27 −0
Merged

Prevent Player Simulator crashes from fake-player dimension transitions (Ex Deorum End Cake interaction) #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8a279
Initial plan
Copilot May 8, 2026
7b1e9b3
Fix fake player dimension change crash path
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/org/cyclops/integratedtunnels/core/ExtendedFakePlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
import net.minecraft.core.BlockPos;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.effect.MobEffectInstance;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.GameType;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.portal.DimensionTransition;
import net.neoforged.neoforge.common.CommonHooks;
import net.neoforged.neoforge.common.util.FakePlayer;
import net.neoforged.neoforge.event.EventHooks;
import org.jetbrains.annotations.Nullable;

import java.util.UUID;

Expand Down Expand Up @@ -97,4 +100,9 @@ public void updateActiveHandSimulated() {
public void startSleeping(BlockPos blockPos) {
// Do nothing
}

@Override
public @Nullable Entity changeDimension(DimensionTransition transition) {
return this;
}
}
19 changes: 19 additions & 0 deletions src/main/java/org/cyclops/integratedtunnels/gametest/GameTestsPlayerSimulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@
import net.minecraft.core.Direction;
import net.minecraft.gametest.framework.GameTest;
import net.minecraft.gametest.framework.GameTestHelper;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityType;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.Items;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.LeverBlock;
import net.minecraft.world.level.block.entity.ChestBlockEntity;
import net.minecraft.world.level.portal.DimensionTransition;
import net.neoforged.neoforge.gametest.GameTestHolder;
import net.neoforged.neoforge.gametest.PrefixGameTestTemplate;
import org.cyclops.integrateddynamics.RegistryEntries;
Expand All @@ -23,6 +27,7 @@
import org.cyclops.integrateddynamics.core.evaluate.variable.ValueTypes;
import org.cyclops.integrateddynamics.core.helper.PartHelpers;
import org.cyclops.integratedtunnels.Reference;
import org.cyclops.integratedtunnels.core.ExtendedFakePlayer;
import org.cyclops.integratedtunnels.part.PartTypes;
import org.cyclops.integratedtunnels.part.aspect.TunnelAspectWriteBuilders;
import org.cyclops.integratedtunnels.part.aspect.TunnelAspects;
Expand All @@ -38,6 +43,20 @@ public class GameTestsPlayerSimulator {
public static final int TIMEOUT = 2000;
public static final BlockPos POS = BlockPos.ZERO.offset(2, 1, 2);

@GameTest(template = TEMPLATE_EMPTY, timeoutTicks = TIMEOUT)
public void testPlayerSimulatorFakePlayerChangeDimensionNoOp(GameTestHelper helper) {
ServerLevel level = helper.getLevel();
ServerLevel endLevel = level.getServer().getLevel(Level.END);
helper.assertTrue(endLevel != null, "The End level is not available");

ExtendedFakePlayer fakePlayer = new ExtendedFakePlayer(level);
Entity returnedEntity = fakePlayer.changeDimension(new DimensionTransition(endLevel, fakePlayer, DimensionTransition.DO_NOTHING));

helper.assertValueEqual(returnedEntity, fakePlayer, "Fake player changeDimension return value is incorrect");
helper.assertValueEqual(fakePlayer.level(), level, "Fake player changed dimensions unexpectedly");
helper.succeed();
}

@GameTest(template = TEMPLATE_EMPTY, timeoutTicks = TIMEOUT)
public void testPlayerSimulatorMilkCow(GameTestHelper helper) {
// Place cable
Expand Down
Loading