refactor: Separate venvs into subdirectories for Flatpak and host#237
Open
refactor: Separate venvs into subdirectories for Flatpak and host#237
Conversation
shymega
force-pushed
the
shymega/isolate-venvs-flatpak-host
branch
from
10ea84a to
54398dc
Compare
Collaborator
|
Seems reasonable, you tried to compile then. |
Member
Author
|
I can add logic to migrate the 'old' venv to the new structure, yes. But I'd rather not have it in a flat structure. Nested is better, because it means the launcher dir is tidier. I will add logic in a later commit. |
shymega
force-pushed
the
shymega/isolate-venvs-flatpak-host
branch
6 times, most recently
from
bfdaee1 to
d01cf67
Compare
Member
Author
|
Added a migration function. |
shymega
force-pushed
the
shymega/isolate-venvs-flatpak-host
branch
from
d01cf67 to
59b7263
Compare
Collaborator
|
Looks pretty good, how ready is this now. |
Member
Author
Should be fairly ready. I'll test this weekend, as I'm free. |
shymega
force-pushed
the
shymega/isolate-venvs-flatpak-host
branch
2 times, most recently
from
76e54ef to
2a3d1f5
Compare
marvin1099
added
the
test me
To avoid ELF binary conflicts between Flatpak and host environments, virtual environments are now created in separate subdirectories: - wemod_venv/flatpak: For Flatpak sandbox environment - wemod_venv/host: For host system environment This ensures that binaries compiled for one environment don't get executed in the other, preventing "wrong ELF class" errors. Changes: - mk_venv(): Creates venv in appropriate subdirectory based on environment - venv_manager(): Checks for existing venv in correct subdirectory - check_flatpak(): Creates host venv in wemod_venv/host with dependencies - Adds venv detection to prevent infinite rerun loops
marvin1099
force-pushed
the
shymega/isolate-venvs-flatpak-host
branch
from
2a3d1f5 to
48f72fb
Compare
Collaborator
|
Should we move a old venv, or just delete it or do nothing, what do you think. |
Collaborator
|
Also PR confirmed working on my end. |
marvin1099
removed
the
test me
Member
Author
|
I think it'd be OK to recreate it. There's no harm in that.
…On 01.05.2026 01:52, Marvin1099 wrote:
marvin1099 left a comment (DeckCheatz/wemod-launcher#237)
Should we move a old venv, or just delete it or do nothing, what do you think.
--
Reply to this email directly or view it on GitHub:
#237 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Member
Author
|
OK.
I've identified a bug on CachyOS at least, where the `host` folder is
repeated at least ten times in the path, so I need to fix that.
…On 01.05.2026 01:57, Marvin1099 wrote:
marvin1099 left a comment (DeckCheatz/wemod-launcher#237)
Also PR confirmed working on my end.
--
Reply to this email directly or view it on GitHub:
#237 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
marvin1099
added
the
under development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid ELF binary conflicts between Flatpak and host environments, virtual environments are now created in separate subdirectories:
This ensures that binaries compiled for one environment don't get executed in the other, preventing "wrong ELF class" errors.
Changes: