Added corpus pytests to QA workflow. #138
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the QA workflow to run corpus pytests by adding steps to clone an external repository, install its dependencies, and run its tests.
- Removed an installation command from the dependencies step.
- Added three new steps for cloning the corpus repository, installing its tests, and executing the tests.
.github/workflows/python-test.yml
Outdated
| run: | | ||
| python -m pip install setuptools_git_versioning | ||
| python -m setuptools_git_versioning | ||
| - name: Clone the e-ark-corpus git repo |
There was a problem hiding this comment.
Changing directories in one step (using 'cd') will not persist into later steps. Consider using the 'working-directory' attribute in subsequent steps or combine these steps into one so that the intended directory context is maintained.
There was a problem hiding this comment.
Pull Request Overview
This PR integrates corpus pytests into the QA workflow by modifying the CI pipeline to run tests using an external test corpus.
- Removed an installation command for testing dependencies.
- Added a new job that clones and runs tests from the external EARK IP test corpus repository.
Comments suppressed due to low confidence (1)
.github/workflows/python-test.yml:35
- Verify that the removal of 'pip install ".[testing]"' is intentional, as it might affect the setup of testing dependencies in the workflow.
- pip install ".[testing]"
| python -m setuptools_git_versioning | ||
| - name: Install and run the EARK IP test corpus tests | ||
| run: | | ||
| git clone https://github.com/DILCISBoard/eark-ip-test-corpus.git |
There was a problem hiding this comment.
Consider specifying a commit hash or tag when cloning the test corpus repository to ensure consistent and reproducible test results.
| git clone https://github.com/DILCISBoard/eark-ip-test-corpus.git | |
| git clone --branch <commit-hash-or-tag> https://github.com/DILCISBoard/eark-ip-test-corpus.git |
There was a problem hiding this comment.
Not known necessarily and I think we always want the latest version. Please confirm @dockmd
No description provided.