Skip to content

Added corpus pytests to QA workflow. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlwilson wants to merge 3 commits into
base: integration
Choose a base branch
from
Open

Added corpus pytests to QA workflow. #138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
343dc53
Added corpus pytests to QA workflow.
carlwilson Apr 2, 2025
5b5caba
FIX: Combine steps to retain directory.
carlwilson Apr 2, 2025
d8f34de
Merge branch 'integration' into test/corpus-pytests
carlwilson Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/python-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ".[testing]"
- name: Install python package
run: |
pip install --editable ".[testing]"
Expand All @@ -49,3 +48,9 @@ jobs:
run: |
python -m pip install setuptools_git_versioning
python -m setuptools_git_versioning
- name: Install and run the EARK IP test corpus tests
run: |
git clone https://github.com/DILCISBoard/eark-ip-test-corpus.git
Copy link

Copilot AI Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying a commit hash or tag when cloning the test corpus repository to ensure consistent and reproducible test results.

Suggested change
git clone https://github.com/DILCISBoard/eark-ip-test-corpus.git
git clone --branch <commit-hash-or-tag> https://github.com/DILCISBoard/eark-ip-test-corpus.git

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@carlwilson carlwilson Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not known necessarily and I think we always want the latest version. Please confirm @dockmd

cd eark-ip-test-corpus/tests
pip install -r requirements.txt
pytest
Loading