Skip to content

Deprecate enum-like property access mechanism in AbstractMasterEntity #6470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 4.3
Choose a base branch
from
+10 −1
Open

Deprecate enum-like property access mechanism in AbstractMasterEntity #6470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eadb20
deprecate: enum-like property access mechanism in AbstractMasterEntity
nanasess Oct 3, 2025
891954c
Merge branch '4.3' into deprecated-enum-emulate
nanasess Oct 3, 2025
5c8c521
Merge branch '4.3' into deprecated-enum-emulate
dotani1111 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Eccube/Entity/Master/AbstractMasterEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ public function __get($name)

public function __set($name, $value)
{
throw new \InvalidArgumentException();
// Allow Doctrine ORM 3.x lazy ghost objects to hydrate properties
// see also. https://github.com/EC-CUBE/ec-cube/issues/6469
}

public static function __callStatic($name, $arguments)
Expand All @@ -144,6 +145,14 @@ public static function __callStatic($name, $arguments)

protected static function getConstantValue($name)
{
@trigger_error(
sprintf(
'The enum-like property access mechanism is deprecated. Use PHP 8.2+ trait constants instead: trait MyTrait { public const %s = value; }',
$name
),
E_USER_DEPRECATED
);

if (in_array($name, ['id', 'name', 'sortNo'])) {
throw new \InvalidArgumentException();
}
Expand Down
Loading