Add method to decide family action #1107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a method
EnsEMBL::Web::Component::Gene::Compara_Portal::_get_compara_family_page_action, which determines the action ofFamilylinks in a Compara portal view.As currently implemented, this will have no effect unless the method is overridden to return an alternative action value.
In conjunction with eg-web-common PR 150, this pull request makes it possible to point Compara portal
Familylinks to theGene_familiesview of Non-Vertebrate genes that have such data.Views affected
This change may affect Compara portal views, but only if the
EnsEMBL::Web::Component::Gene::Compara_Portal::_get_compara_family_page_actionmethod is overridden.Possible complications
None expected.
Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)