feat(semantic-tokens): update shadow token styles#14152
feat(semantic-tokens): update shadow token styles#14152
Conversation
| --calcite-opacity-dark: 0.85; | ||
| --calcite-opacity-full: 1; | ||
| --calcite-shadow-none: 0 0 0 0 rgba(0, 0, 0, 0); | ||
| --calcite-shadow-sm: 0 2px 8px 0 rgba(0, 0, 0, 0.1), 0 2px 8px 0 rgba(0, 0, 0, 0.04); |
There was a problem hiding this comment.
This is where we'd want this line to be:
--calcite-shadow-sm: 0 2px 8px 0 var(--calcite-color-shadow-3), 0 2px 8px 0 var(--calcite-color-shadow-1);
| --calcite-opacity-full: 1; | ||
| --calcite-shadow-none: 0 0 0 0 rgba(0, 0, 0, 0); | ||
| --calcite-shadow-sm: 0 2px 8px 0 rgba(0, 0, 0, 0.1), 0 2px 8px 0 rgba(0, 0, 0, 0.04); | ||
| --calcite-shadow-md: 0 6px 20px -4px rgba(0, 0, 0, 0.1), 0 4px 12px -2px rgba(0, 0, 0, 0.08); |
There was a problem hiding this comment.
This is where we'd want this line to be:
--calcite-shadow-md: 0 6px 20px -4px var(--calcite-color-shadow-3), 0 4px 12px -2px var(--calcite-color-shadow-2);
|
@jcfranco, I created a fresh PR. This is the ideal way that things would be set up in our src tokens. I also ran test snapshots just to show what it would look like before any changes. See above comments for details |
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
Related Issue: #10050
Summary
Semantic color token additions:
color.shadow.1rgba({core.color.neutral.blk-240}, {core.opacity.4})rgba({core.color.neutral.blk-240}, {core.opacity.12})color.shadow.2rgba({core.color.neutral.blk-240}, {core.opacity.8})rgba({core.color.neutral.blk-240}, {core.opacity.12})color.shadow.3rgba({core.color.neutral.blk-240}, {core.opacity.10})rgba({core.color.neutral.blk-240}, {core.opacity.16})Semantic shadow token updates:
semantic.color.shadow.sm"x": "{core.size.default.none}","y": "{core.size.default.2}","blur": "{core.size.default.8}","spread": "{core.size.default.none}","color": "{semantic.color.shadow.3}""x": "{core.size.default.none}","y": "{core.size.default.2}","blur": "{core.size.default.8}","spread": "{core.size.default.none}","color": "{semantic.color.shadow.1}"semantic.color.shadow.md"x": "{core.size.default.none}","y": "{core.size.default.6}","blur": "{core.size.default.20}","spread": "-{core.size.default.4}","color": "{semantic.color.shadow.3}""x": "{core.size.default.none}","y": "{core.size.default.4}","blur": "{core.size.default.12}","spread": "-{core.size.default.2}","color": "{semantic.color.shadow.2}"Semantic shadow token refactors:
semantic.color.shadow.none"x": "{core.size.default.none}","y": "{core.size.default.none}","blur": "{core.size.default.none}","spread": "{core.size.default.none}","color": "rgba({core.color.neutral.blk-240}, {core.opacity.0})"