Repository navigation
chore: upgrade to PHPStan 2 - #44
Merged
Merged
Conversation
PHPStan 1.x fails on the NodeBuilder generics of current symfony/config, which keeps the CI red on main. Claude-Session: https://claude.ai/code/session_01G2xLjqD8vZ7Ys3inHx4ax5
shyim
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
phpstanjob onmaincurrently fails withbecause PHPStan 1.x cannot resolve the generics that current symfony/config declares. This upgrades to PHPStan 2 and resolves the three findings it reports at level max:
FlowEventException: nullsafe access on the left side of??FlowLogSubscriber:getThrowable()result ismixed, narrow toThrowable|null; drop an ignore that no longer matches an errortreatPhpDocTypesAsCertain: false, so the runtimeis_string()guard ongetPrimaryKey()(array|string) stayshttps://claude.ai/code/session_01G2xLjqD8vZ7Ys3inHx4ax5