[OPTIMIZATION] Only center the strumlines once in Blazin' #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: medium
AbnormalPoof
added
status: pending triage
AbnormalPoof
changed the title
Hundrec
force-pushed
the
better-blazin
branch
from
a8c14bf to
2c0411d
Compare
|
I don't think this PR fixes this issue, should I create a fix for it? |
|
No need to, it was already fixed in 0437c91 |
|
ah okay thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Funkin PR
N/A
Linked Issues
N/A
Description
Instead of checking if the strumline has been moved every frame, simply just move it at the beginning of the countdown. (this caused me a lot of issues when creating my middlescroll mod)
Screenshots/Videos
N/A